Reviewing community pull requests

As a Puppet community member, you can offer feedback on someone else's contributed code.

When reviewing pull requests, any of the following contributions are helpful:

  • Review the code for any obvious problems.

  • Provide feedback based on personal experience on the subject.

  • Test relevant examples on an untested platform.

  • Look at potential side effects of the change.

  • Examine discrepancies between the original issue and the pull request.

Add your comments and questions to the pull request, pointing out any specific lines that need attention. Be sure to respond to any questions the contributor has about your comments.